[Relay][Frontend][Torch] fix pytorch frontend not support logical or#16400
Merged
masahi merged 1 commit intoapache:mainfrom Jan 16, 2024
Merged
Conversation
taomiao
force-pushed
the
fix/pytorch_frontend_not_support_logical_or
branch
2 times, most recently
from
75ab5f8 to
0f45ef9
Compare
Contributor
Author
t-vi
suggested changes
Jan 16, 2024
Contributor
t-vi
left a comment
t-vi
left a comment
There was a problem hiding this comment.
Thank you for submitting the PR. The logical_or looks good, I have doubts about the __or__ .
| "torchvision::deform_conv2d": self.deform_conv2d, | ||
| "aten::unbind": self.unbind, | ||
| "aten::__and__": self.logical_and, | ||
| "aten::__or__": self.logical_or, |
Contributor
There was a problem hiding this comment.
I'm afraid this is not tested and also not quite right.
While torch.logical_or(torch.tensor(2), torch.tensor(1)) gives tensor(True),
torch.ops.aten.__or__(torch.tensor(2), torch.tensor(1)) gives tensor(3)
(and torch.tensor(2) or torch.tensor(1)) gives tensor(2), so it is different yet)
Contributor
Author
There was a problem hiding this comment.
Ok, I removed aten::__or__ from the convert_map.
Contributor
There was a problem hiding this comment.
Thank you. Seems good to me now.
taomiao
force-pushed
the
fix/pytorch_frontend_not_support_logical_or
branch
from
0f45ef9 to
c9d5fc0
Compare
masahi
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add logical_or op to relay pytorch frontend. #16399